Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11725] [#11744] Update logs compilation function + version filter #11726

Merged
merged 5 commits into from
Apr 17, 2022

Conversation

wkurniawan07
Copy link
Member

@wkurniawan07 wkurniawan07 commented Apr 11, 2022

Fixes #11725
Fixes #11744

Notably, this removes the classes generated from protobuf which are added in #10930, which accounts for 9,395 lines of code deletion.

@wkurniawan07 wkurniawan07 added the c.Feature User-facing feature; can be new feature or enhancement to existing feature label Apr 11, 2022
@wkurniawan07 wkurniawan07 added this to the V8.14.0 milestone Apr 11, 2022
@wkurniawan07 wkurniawan07 force-pushed the remove-legacy-error-logs branch 2 times, most recently from 6dd603d to 06e05c7 Compare April 16, 2022 09:52
@wkurniawan07 wkurniawan07 changed the title [#11725] Update logs compilation function to use the same logging infrastructure as maintainer logs [#11725] [#11744] Update logs compilation function + version filter Apr 16, 2022
@wkurniawan07 wkurniawan07 force-pushed the remove-legacy-error-logs branch 2 times, most recently from 341c182 to 623d4b9 Compare April 17, 2022 08:49
@wkurniawan07 wkurniawan07 marked this pull request as ready for review April 17, 2022 09:20
@wkurniawan07 wkurniawan07 added the s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging label Apr 17, 2022
@wkurniawan07 wkurniawan07 merged commit 7d4873e into TEAMMATES:master Apr 17, 2022
@wkurniawan07 wkurniawan07 deleted the remove-legacy-error-logs branch April 17, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c.Feature User-facing feature; can be new feature or enhancement to existing feature s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
1 participant