[#11497] Fix server error when retrieving log entries from cloud logging #11714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@halfwhole possible to treat this as a hot-patch candidate and rebase this PR against Edit: will be making a fresh release from |
wkurniawan07
approved these changes
Apr 10, 2022
wkurniawan07
added
c.Bug
ziqing26
pushed a commit
to ziqing26/teammates
that referenced
this pull request
Apr 11, 2022
…loud logging (TEAMMATES#11714) Co-authored-by: Wilson Kurniawan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11497
The issue should occur due to the call to
iterateAll()happening afterlogging.close(), so this fix shifts the call toiterateAllto before closing the logging resource. (props to @t-cheepeng for identifying the issue)Have tested on staging and the functionality still works as before, but since I can't reproduce the issue on my staging will need some external help to check that the fix works as intended.