[#11150] Search page: Remove unnecessary panel

[tamrakarsweta220]

Fixes #11150

PR Checklist

Ensure that you have:

• Read and understood our PR guideline: https://github.com/TEAMMATES/teammates/blob/master/docs/process.md#step-4-submit-a-pr
  • Added the issue number to the "Fixes" keyword above
  • Titled the PR as specified in the above mentioned document
• Made your changes on a branch other than master and release
• Gone through all the changes in this PR and ensured that:
  • They addressed one (and only one) issue
  • No unintended changes were made
• Run and passed static analysis: ./gradlew lint and npm run lint
• Added/updated tests, if changes in functionality were involved
• Added/updated documentation to public APIs (classes, methods, variables), if applicable

Outline of Solution

I made two changes to the instructions on the student search page.

1. Updated the search instruction to let users know that they can search by name or email
2. Gave an example for using quotations in the search bar to search for specific phrases at the end of the instruction.

I also removed the "student" header and the outer panel from the search result table.

This is how the changes currently look like:

[FergusMok]

Hello, thank you for contributing to TEAMMATES. It seems like some linting tests are failing too

You can refer to the documentation for linting . To update the snapshots, you can run npm run test -- --updateSnapshot, or alternatively, run npm run test, and then press the button "u".

[fsgmhoward]

From your screenshot, it looks like all your tests are failing. Have you executed this before you run the test:

./gradlew generateTypes

If that is the case, you will need to execute this before you run the test. This command generates frontend types from backend description files. After that, you can run test and update snapshot based on displayed information (see @FergusMok 's comment above).

npm run test

Even though the change is minor, it is still suggested to follow steps in Development Guide to run the development server and test the functionality.

[teammates-bot]

Hi @tamrakarsweta220, these parts of your pull request do not appear to follow our contributing guidelines:

1. PR Description
   • Should contain GitHub keyword to auto-close issue it fixes: Refer here for a list of accepted keywords.

[tamrakarsweta220]

I followed the instructions as suggested above by @fsgmhoward and @FergusMok and updated the snapshot, so the component tests have passed. I am still having issues with lint though. I tried running the npm run lint command for the master branch too, but it's the same. The lint checks fail in the master branch too.

Also, the teammates bot keeps telling me that my PR "Should contain GitHub keyword to auto-close issue it fixes: Refer here for a list of accepted keywords." I wrote "fixes" based on the documentation but it's still showing me this error. I capitalized the "f" in "fixes" and then put it in lowercase too, but the error didn't go away. So, I am not sure what is causing the error. Is there something else that I am missing?

[fsgmhoward]

I followed the instructions as suggested above by @fsgmhoward and @FergusMok and updated the snapshot, so the component tests have passed. I am still having issues with lint though. I tried running the npm run lint command for the master branch too, but it's the same. The lint checks fail in the master branch too.

Also, the teammates bot keeps telling me that my PR "Should contain GitHub keyword to auto-close issue it fixes: Refer here for a list of accepted keywords." I wrote "fixes" based on the documentation but it's still showing me this error. I capitalized the "f" in "fixes" and then put it in lowercase too, but the error didn't go away. So, I am not sure what is causing the error. Is there something else that I am missing?

Usually we do with "Fixes". I am not sure whether it is accepted or not in lower case.

For the lint issue, I see that all checks passed already. It fails on your local machine because the lint program takes auto-generated files, which will fail it. You have to take a look at which file fails the linting test. If it is not those you made changes, then you are fine. If you are interested, the related issue is this: #11564

[teammates-bot]

Hi @tamrakarsweta220, these parts of your pull request do not appear to follow our contributing guidelines:

1. PR Description
   • Should contain GitHub keyword to auto-close issue it fixes: Refer here for a list of accepted keywords.

[FergusMok]

Good job, the table looks good. Just some small considerations, and remember to update the branch to master

[tamrakarsweta220]

@FergusMok Hi, I just made the changes you suggested. So, I'm commenting for code review again. Thanks!

[fsgmhoward]

LGTM.

[FergusMok]

LGTM! 👍