Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#11572] Notification Feature - PUT notification route #11665

Merged
merged 25 commits into from
Mar 27, 2022
Merged

[#11572] Notification Feature - PUT notification route #11665

merged 25 commits into from
Mar 27, 2022

Conversation

NicolasCwy
Copy link
Contributor

Part of #11572

To be merged after #11651 and #11660

Outline of Solution
Add PUT notification route to update notifications.

@teammates-bot
Copy link

Hi @NicolasCwy, these parts of your pull request do not appear to follow our contributing guidelines:

  1. PR Description
    • Should contain GitHub keyword to auto-close issue it fixes: Refer here for a list of accepted keywords.

@NicolasCwy NicolasCwy marked this pull request as ready for review March 21, 2022 08:56
@NicolasCwy NicolasCwy added the s.OnHold The issue/PR's validity has been put on hold pending some other event label Mar 21, 2022
@NicolasCwy NicolasCwy added s.ToReview The PR is waiting for review(s) and removed s.OnHold The issue/PR's validity has been put on hold pending some other event labels Mar 22, 2022
@fsgmhoward fsgmhoward mentioned this pull request Mar 23, 2022
Merged
3 tasks
@NicolasCwy NicolasCwy mentioned this pull request Mar 24, 2022
Merged
2 tasks
@jianhandev jianhandev added s.Ongoing The PR is being worked on by the author(s) and removed s.OnHold The issue/PR's validity has been put on hold pending some other event labels Mar 25, 2022
@NicolasCwy NicolasCwy added s.ToReview The PR is waiting for review(s) and removed s.Ongoing The PR is being worked on by the author(s) labels Mar 26, 2022
@TEAMMATES TEAMMATES deleted a comment from teammates-bot Mar 27, 2022
@TEAMMATES TEAMMATES deleted a comment from teammates-bot Mar 27, 2022
jianhandev
jianhandev reviewed Mar 27, 2022
View reviewed changes
Copy link
Contributor

@jianhandev jianhandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

src/main/java/teammates/ui/request/NotificationBasicRequest.java Outdated Show resolved Hide resolved
fsgmhoward
fsgmhoward approved these changes Mar 27, 2022
View reviewed changes
Copy link
Member

@fsgmhoward fsgmhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jianhandev jianhandev added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.ToReview The PR is waiting for review(s) labels Mar 27, 2022
@jianhandev jianhandev merged commit c6e92a9 into TEAMMATES:notification-feature Mar 27, 2022
fsgmhoward pushed a commit that referenced this pull request Apr 1, 2022
@NicolasCwy @fsgmhoward
[#11572] Notification Feature - PUT notification route (#11665)
d620b00 
* Add PUT route

* Add PUT to notification service

* Change startTime and endTime to long
fsgmhoward pushed a commit that referenced this pull request Apr 1, 2022
@NicolasCwy @fsgmhoward
[#11572] Notification Feature - PUT notification route (#11665)
92d5fe0 
* Add PUT route

* Add PUT to notification service

* Change startTime and endTime to long
jianhandev pushed a commit that referenced this pull request Apr 5, 2022
@NicolasCwy
[#11572] Notification Feature - PUT notification route (#11665)
836565c 
* Add PUT route

* Add PUT to notification service

* Change startTime and endTime to long
jianhandev pushed a commit that referenced this pull request Apr 5, 2022
@NicolasCwy
[#11572] Notification Feature - PUT notification route (#11665)
fc401d2 
* Add PUT route

* Add PUT to notification service

* Change startTime and endTime to long
jianhandev pushed a commit that referenced this pull request Apr 6, 2022
@NicolasCwy
[#11572] Notification Feature - PUT notification route (#11665)
92bf949 
* Add PUT route

* Add PUT to notification service

* Change startTime and endTime to long
jianhandev pushed a commit that referenced this pull request Apr 6, 2022
@NicolasCwy @jianhandev
[#11572] Notification Feature - PUT notification route (#11665)
7756f04 
* Add PUT route

* Add PUT to notification service

* Change startTime and endTime to long
@wkurniawan07 wkurniawan07 added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Apr 6, 2022
@wkurniawan07 wkurniawan07 added this to the V8.13.0 milestone Apr 6, 2022
@NicolasCwy NicolasCwy deleted the 11572-put-notification-route branch January 22, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianhandev jianhandev jianhandev approved these changes

@fsgmhoward fsgmhoward fsgmhoward approved these changes

@t-cheepeng t-cheepeng Awaiting requested review from t-cheepeng

Assignees
No one assigned
Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@NicolasCwy @teammates-bot @jianhandev @fsgmhoward @wkurniawan07 @ziqing26