Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructors creating sessions: response visible time should be 'not now' by default #12517

Closed
damithc opened this issue Jul 14, 2023 · 3 comments · Fixed by #12518
Closed

Instructors creating sessions: response visible time should be 'not now' by default #12517

damithc opened this issue Jul 14, 2023 · 3 comments · Fixed by #12518
Labels
c.Bug Bug/defect report p.High Significant impact; would like to do in the next few releases

Comments

@damithc
Copy link
Contributor

damithc commented Jul 14, 2023

When an instructors is creating a new session,

Current:

image

The default Make response visible time is empty.

Expected:

Should be set to Not now.

Otherwise, there will be an error message upon saving.

Seems like a regression caused by V8.28
@damithc damithc added p.High Significant impact; would like to do in the next few releases c.Bug Bug/defect report labels Jul 14, 2023
@damithc
Copy link
Contributor Author

damithc commented Jul 14, 2023

Possibly caused by #12498
@Zxun2 can have a look?

@damithc damithc mentioned this issue Jul 14, 2023
Closed
4 tasks
@github-actions github-actions bot mentioned this issue Jul 14, 2023
Open
@Zxun2 Zxun2 mentioned this issue Jul 14, 2023
Merged
@Zxun2
Copy link
Contributor

Zxun2 commented Jul 14, 2023 •
edited
Loading

Apologies, I have submitted a PR for this!

@damithc
Copy link
Contributor Author

damithc commented Jul 14, 2023

Apologies, I have submitted a PR for this!

No worries @Zxun2 . It's a rite of passage 😀
Thanks for the quick response.

samuelfangjw pushed a commit that referenced this issue Jul 15, 2023
@Zxun2 @samuelfangjw
[#12517] Instructors creating sessions: response visible time should …
f2ec14f 
…be 'not now' by default (#12518)
This was referenced Jul 23, 2023
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c.Bug Bug/defect report p.High Significant impact; would like to do in the next few releases
Projects
None yet
Milestone
No milestone
2 participants
@damithc @Zxun2