-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
과제1 정건희 제출_3 #9
Open
MisterJerry123
wants to merge
20
commits into
TEAM-ALOM:main
Choose a base branch
from
MisterJerry123:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
과제1 정건희 제출_3 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toryImpl에서 저장하는 방식으로 변경)
저거 하나빼곤 잘하셨씁니당 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타이틀
stateflow 활용 간단한 메모 앱 만들기 (stateflow-> stateflow+Repository pattern)
PR 생성 날짜
2024/10/11
PR 내용
기존 LiveData로 구현한 방식에서 stateflow를 이용하여 설계잘못 설계한 비즈니스 로직 개선로직 구성
질문
SharedPreference에 저장하는 로직은 MainActivity에 들어가야하나요 아니면 ViewModel에 들어가야 하나요? (Repository 패턴으로 해결)