Use Remote Group When Adding Resp Link on Modem #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The group on responder links is the "remote_group". This was correct in the devices/Base.py but was somehow not updated in Modem.py. Also fix bug with link data on Modem _db_update. It is a bit confusing, but when calling _db_add_### at the end of the function the call is to the remote device, so the local_data is actually remote_data. Copy Base Device DB_Update Tests into Test Modem. Add tests for multigroup responder links on Modem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This is a significant bug fix. Not sure how long this has been an issue. I only noticed it when I had to replace a PLM.
The Issue
When pairing a multigroup device such as a keypadlinc, remote, motion, ... The responder links for the secondary groups (not 0/1) were not being added to the modem.
This was happening because
_db_updateon the modem was treating the local_group as the scene group number for responder links. Since all responder links on the modem have a local_group of0x01this essentially meant that only one responder link would be added to the modem per device since all responder links looked the same.The Solution
The solution is to use the remote_group as the scene group number on responder links. This code is written properly for all other devices except the modem, so I just copied the same code.
Additional information
I am not sure how long this has been happening. The code I modified is 4 years old. But I believe things were working at some point. Strange
Checklist