Improve UI Error on Unknown Flags in Set Flags #313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions only show up in the LOG. UI, Error, and Warning are sent out to the user UI. I will add some suggestions on logging to the developer instructions.
There was no need to raise an exception here, plus without a LOG message, the user doesn't get very helpful instructions.
Previous:
Now:
This also highlights the need to abstract more of the code. Rather than have to go around to multiple places to fix this, it should only be in one place.