Minor Database Handling Fixes #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increment is really what was needed. Gracefully handles a delta of None for example if a user used refresh=False Partially Fixes TD22057#292 Fixes TD22057#243
This was
linked to
issues
Dec 31, 2020
krkeegan
added a commit
to krkeegan/insteon-mqtt
that referenced
this pull request
Dec 31, 2020
Found a bug in how partial messages are reinserted back into the _write_queue. But this is not what is causing TD22057#293 as a different error would appear. Added Unit Tests of Write_to_Link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
set_deltafunction toincrement_delta. Increment is really what was needed, plus this way it gracefully handles a delta of None for example if a user used refresh=False. Unit tests included.I also changed the clear function so that it does not delete the db file, but merely clears the entry lists and associated values. Most importantly it leaves the meta dictionary intact. So IOLincs will function properly after a refresh, and user settings such as battery level will not be erased.
Partially Fixes #292
Fixes #243