Issue 384 fix cli script #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accidentally pushed to main hence merging to issue branch
…n_up_temp Update filename for newer versions and fix incorrect variable in clean_up_temp
mushahidq
requested review from
KendallWeihe,
nitro-neal,
shamilovtim,
diehuxx,
frankhinek and
leordev
as code owners
|
Awesome! I'll ping @KendallWeihe and other teammates to test this. |
nitro-neal
reviewed
Oct 11, 2024
nitro-neal
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
tested and working on my box,
approving even though we have test vector failures as this is only changing the .sh script.
next time to get rid of compile errors you have to pull in the submodule test vectors by using:
git submodule update --init
Thank you very much!! 🥇
Co-authored-by: nitro-neal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR fixes Issue 384 to display error messages in Web5 CLI installation script and make it a bit more verbose.
This PR [adds/removes/fixes/replaces] this [feature/bug/etc].
Related Tickets & Documents
Resolves #384
Mobile & Desktop Screenshots/Recordings
Added code snippets?
Added tests?
No tests? Add a note
Updated installation script for web5cli
Added to documentation?
No docs? Add a note
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?