Implement partial APID 0.1.0 with UDL bindings #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe and
frankhinek
as code owners
KendallWeihe
force-pushed
the
kendall/empty-udl-apid-0.1.0_with-dictionaries_wrangling
branch
from
bf4763c
to
fa13331
Compare
22 tasks
nitro-neal
reviewed
Jun 17, 2024
nitro-neal
reviewed
Jun 17, 2024
nitro-neal
reviewed
Jun 17, 2024
nitro-neal
reviewed
Jun 17, 2024
bind/uniffi/src/lib.rs
Outdated
| VerifiableCredential as RcbVerifiableCredentialData, | ||
| }, | ||
| }, | ||
| dids::{ |
There was a problem hiding this comment.
ahh I thought the top level was going to be exported as RcbDids, to clear up the namespace in Kotlin.. but.. we can handle it at the kotlin layer :hmm:
nitro-neal
reviewed
Jun 17, 2024
bind/uniffi/src/web5.udl
Outdated
| string? fragment; | ||
| }; | ||
|
|
||
| interface RcbDid { |
There was a problem hiding this comment.
or maybe the kotlin will see RcbDid instead of "Did" but yea either can work!
nitro-neal
reviewed
Jun 17, 2024
KendallWeihe
commented
Jun 17, 2024
| type Result<T> = std::result::Result<T, JwkError>; | ||
|
|
||
| impl Jwk { | ||
| pub fn compute_thumbprint(&self) -> Result<String> { |
There was a problem hiding this comment.
compute_thumbprint() isn't in the APID, but it's here as an implementation detail
over time we should consider adding it to the APID (but keeping lean for now)
KendallWeihe
deleted the
kendall/empty-udl-apid-0.1.0_with-dictionaries_wrangling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements partial APID v0.1.0 proposed in #229 with comprehensive UDL bindings. This is not considered to be a complete implementation, but implements enough to unblock downstream Kotlin binded implementation (cc @nitro-neal ). The changes are compartmentalized to a new
web5::apidmodule, and does not remove any of the priorweb5code; the priorweb5code still has code for reference (namely, VC, did:dht and did:web) which needs to be subsequently moved into thisapidmodule, whereafter everything in theapidmodule will be moved into the rootweb5module.Missing Pieces
josekitAll of the above implementation will be implemented in subsequent pull requests.
Known Limitations
Filter'scontainsproperty is problematic, temporarily removed supportBoth of the above limitations will be solvable, but may require additional development on the Kotlin side of the fence, so for the sake of agility I am temporarily removing support as to unblock kt development.