Replace usage of nimbusds Algorithm and Curve with our own enums #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te AlgorithmId enum. probably wrong. very drafty
jiyoonie9
changed the title
This was
linked to
issues
Feb 14, 2024
…ntly 1 test failing, investigating
…ve as params in crypto and did methods.
jiyoonie9
requested review from
tomdaffurn,
amika-sq,
mistermoe,
nitro-neal,
phoebe-lew,
diehuxx,
kirahsapong and
frankhinek
as code owners
jiyoonie9
changed the title
mistermoe
reviewed
Feb 15, 2024
mistermoe
reviewed
Feb 15, 2024
| @JvmOverloads | ||
| public fun from(curve: JwaCurve?, algorithm: Jwa? = null): AlgorithmId { | ||
| return when (algorithm to curve) { | ||
| // todo do i need to add the null algo or null curve cases? |
There was a problem hiding this comment.
nop! in fact can ditch algorithm arg entirely
mistermoe
approved these changes
Feb 15, 2024
Co-authored-by: Moe Jangda <[email protected]>
…waCurve and using default enum keyword 'name'
…eded in getVerifier()
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
- Coverage 80.04% 79.59% -0.46%
==========================================
Files 37 38 +1
Lines 2200 2220 +20
Branches 312 316 +4
==========================================
+ Hits 1761 1767 +6
- Misses 299 314 +15
+ Partials 140 139 -1
|
amika-sq
approved these changes
Feb 15, 2024
Co-authored-by: Moe Jangda <[email protected]>
…e-nimbusds-algo-curve
tomdaffurn
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Eliminating use of
CurveandAlgorithmfromnimbusdsdependency and instead using our own enumsJwaCurveandJwa, respectively. Adopting use ofAlgorithmIdwhich is a combination ofJwaCurveandJwa.This PR is the first step to remove dependency on the nimbusds library and preventing exposing their types through our public API surface.
Description
Impact
AlgorithmIdinstead of nimbus Algorithm and nimbus Curve.Follow up tasks
How Has This Been Tested?
Checklist
Before submitting this PR, please make sure:
References
JWA spec