-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolution and Validation of VC CredentialSchema #737
Conversation
🦋 Changeset detectedLatest commit: 8898ff3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-07-19T18:40:49Z |
resolves #711 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
+ Coverage 92.78% 92.80% +0.01%
==========================================
Files 109 109
Lines 29961 29998 +37
Branches 2311 2321 +10
==========================================
+ Hits 27800 27839 +39
+ Misses 2125 2122 -3
- Partials 36 37 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for completing this P1 work item!!
🎖️ 🎸
Some comments.
@nitro-neal for awareness: TBD54566975/schemas#1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 💯 🚀
Resolution and Validation of VC CredentialSchema
This adds the actual fetch and validation of credentialSchema.
kyc schema hosted here - https://purple-charming-snail-690.mypinata.cloud/ipfs/QmZbPpfPXsp4bFQvQvWRaexCu9Vxmj6qkwWerVfPwY9kQS
credential schema validation example:
This code will now fetch the id in credential schema, and then validate that the credential matches the schema