Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Hosting credentialSchema #1456

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Hosting credentialSchema #1456

merged 6 commits into from
Jul 3, 2024

Conversation

EbonyLouis
Copy link
Contributor

@EbonyLouis EbonyLouis commented Jul 2, 2024

To help us get this PR out I hosted our Known Customer Credential Schema on our website.

Issue

Closing out this issue

Direct Link To Preview

https://deploy-preview-1456--tbd-website-developer.netlify.app/schemas/kccSchema.json


Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for tbd-website-developer-new ready!

Name Link
🔨 Latest commit f005a8b
🔍 Latest deploy log https://app.netlify.com/sites/tbd-website-developer-new/deploys/66848f2e3a5d3d00081c0d32
😎 Deploy Preview https://deploy-preview-1456--tbd-website-developer-new.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for tbd-website-developer ready!

Name Link
🔨 Latest commit f005a8b
🔍 Latest deploy log https://app.netlify.com/sites/tbd-website-developer/deploys/66848f2ec8b63100089349f7
😎 Deploy Preview https://deploy-preview-1456--tbd-website-developer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EbonyLouis EbonyLouis marked this pull request as draft July 2, 2024 13:00
@EbonyLouis EbonyLouis marked this pull request as ready for review July 2, 2024 13:18
@EbonyLouis EbonyLouis requested a review from decentralgabe July 2, 2024 13:19
@nitro-neal
Copy link
Contributor

oh this is huge, currently I have one hosted on a random website.

As soon as this goes in I'll update mine to point to tbds and make sure it is working correctly
decentralized-identity/web5-js#737

@nitro-neal
Copy link
Contributor

and by the way,

for us to use this link programmatically, there needs to be a url that resolves to raw json. like this:
https://purple-charming-snail-690.mypinata.cloud/ipfs/QmZbPpfPXsp4bFQvQvWRaexCu9Vxmj6qkwWerVfPwY9kQS

image

and cant have header and stuff:

image

@EbonyLouis
Copy link
Contributor Author

EbonyLouis commented Jul 2, 2024

@nitro-neal I renamed the file so the link needed to be updated. Check this one out theres no heading: https://deploy-preview-1456--tbd-website-developer.netlify.app/schemas/kccSchema.json

Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

This looks good as a starting point, though I imagine we will want to update this schema to include other properties such as the credential id, issuer, issued at time, etc. in the future.

@EbonyLouis
Copy link
Contributor Author

Thanks! @decentralgabe

@EbonyLouis EbonyLouis merged commit 01bd844 into main Jul 3, 2024
17 checks passed
@angiejones angiejones deleted the host-credential-schema branch July 3, 2024 01:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants