generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Crypto Algorithm, KeyManager, and KMS to crypto package #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Hinek <[email protected]>
…entations Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
…coverage Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
…kages Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
===========================================
+ Coverage 65.57% 81.71% +16.13%
===========================================
Files 33 69 +36
Lines 3553 6862 +3309
Branches 198 567 +369
===========================================
+ Hits 2330 5607 +3277
- Misses 1221 1253 +32
Partials 2 2
|
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
mistermoe
reviewed
Jul 9, 2023
mistermoe
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so excited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a significant amount of functionality to the
crypto
package but does so in a way that very minimal changes were made to existing functionality. Once merged, these capabilities will be incrementally used across the Web5.js SDK.common
packageConvert
utility to convert between data and encoding types.Multicodec
utility to make it easier to add and remove Multicodec prefixes, primarily used in the generation of DID identifiers.MemoryStore
implementation that can be used for prototyping or testing key/value stores used by any project.isArrayBufferSlice
,isDefined
, anduniversalTypeOf
crypto
packagecrypto
package previously had a dependency onmultiformats
but the inclusion of the functionality that required this dependency was not crypto specific. As a result, the common functionality was moved to thecommon
package in the form of the newMulticodec
implementation and the DID-specific functionality was moved to thedids
package in the form of a newkeyToMultibaseId
function.checkValidProperty
,checkRequiredProperty
,isBufferKeyPair
,isCryptoKeyPair
,isManagedKey
,isManagedKeyPair
, andrandomUuid
.dids
packageDidKeyApi
implementation previously depended on multicodec and multibase functionality in thecrypto
package that wasn't crypto specific. To reduce unnecessary dependencies in thecrypto
package, the common functionality was moved to thecommon
package in the form of the newMulticodec
implementation and the DID-specific functionality was moved to thedids
package in the form of a newkeyToMultibaseId
function.DidKeyApi
implementation to import the needed functionality.