Feat/update quote orderstatus #68
Conversation
kirahsapong
requested review from
jiyoonie9,
angiejones and
nitro-neal
as code owners
| protocol: nil | ||
| ) | ||
|
|
||
| private func parsedOrderStatus(orderStatus: String) throws -> OrderStatus? { |
There was a problem hiding this comment.
maybe parseOrderStatus to use da verb?
There was a problem hiding this comment.
yeah i also thought verbs are universally clean code for functions. but learned from adam in swift you name them the noun.
| } | ||
| """ | ||
|
|
||
| let orderStatusStringJSON = |
| if let orderStatus = try parsedOrderStatus(orderStatus: orderStatusStringJSON) { | ||
| XCTAssertEqual(orderStatus.metadata.kind, MessageKind.orderStatus) | ||
| } else { | ||
| XCTFail("Order status is not a parsed orderStatus") |
There was a problem hiding this comment.
i want to understand how you expect this test to fail - are we calling this test function with 1 valid orderstatusJson and expecting it to never drop into the else assertion here?
lining up multiple test cases and running them through tests to ensure what we want to see pass passes and what we want to see fail fails is how we've been approaching it
There was a problem hiding this comment.
yeah i always do it that way. missed it going quickly here.
|
closing in favour of allowing init on these |
closes #67
this one's a bit weird because it adds pretty json and escaped json strings to the tests for demonstration purposes - lmk if this is a value add for anyone rn or not
@blackgirlbytes @acekyd
also - rationale for removing init from quote and orderstatus is that these messages should never be initialized from the client, since a client will never send these