This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
secp256k1 key generation, signing, and verification #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amika-sq
requested review from
frankhinek,
mistermoe,
decentralgabe and
ethanwlee
andresuribe87
approved these changes
Dec 18, 2023
| @@ -29,7 +29,8 @@ let package = Package( | |||
| name: "tbDEXTests", | |||
| dependencies: ["tbDEX"], | |||
| resources: [ | |||
| .copy("TestVectors/ed25519") | |||
| .copy("TestVectors/ed25519"), | |||
There was a problem hiding this comment.
Just checking, is it expected for there to be an ed25519 folder?
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements secp256k1 key generation, signing, and verification in Swift.
The secp256k1 algorithm is provided by the secp256k1.swift package. This PR hooks up that algorithm to the various functions we use in web5/tbDEX to convert to/from JWKs.
This PR also uses the test vectors from web5-js to ensure compatibility with our other SDKs. Reviewers can skip over these JSON files, as they're just copy pasted from that repo.
I also went ahead and re-created the tests from
web5-jsthat weren't covered by the test vectors, just to ensure that Swift was doing things properly.