Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

feat: update tbDEXHttpClient to use submitCancel() #104

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

ethan-tbd
Copy link
Contributor

this pr replaces the submitClose() method with submitCancel() since the Close message is reserved for PFI use while the Cancel message is reserved for clients

Copy link

TBD Spec Test Vectors Report

Total Test VectorsTotal Test Cases✅ Passed❌ Failed⚠️ Skipped
10101000
✅ All test vectors passed
Automatically generated at: 2024-08-28T18:24:52.019Z

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (7d7e6d5) to head (2869b5b).

Files with missing lines Patch % Lines
...s/tbDEXTests/HttpClient/tbDEXHttpClientTests.swift 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files          36       36           
  Lines        1374     1374           
=======================================
  Hits         1286     1286           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ethan-tbd ethan-tbd merged commit 0c71c4d into main Aug 29, 2024
1 check passed
@ethan-tbd ethan-tbd deleted the submit-cancel branch August 29, 2024 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants