Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

feat: update tbDEX test vectors #102

Merged
merged 8 commits into from
Aug 28, 2024
Merged

feat: update tbDEX test vectors #102

merged 8 commits into from
Aug 28, 2024

Conversation

ethanwlee
Copy link
Contributor

  • this pr updates the tbDEX test vectors and introduces the following:
    • updates Quote message to include payoutUnitsPerPayinUnit alongwith subtotal and total
    • updates OrderStatus message to include details and the new Status enum
    • updates tbDEXJSONDecoder to handle test vectors that don't have fractional seconds in the createdAt field

Copy link

github-actions bot commented Aug 27, 2024

TBD Spec Test Vectors Report

Total Test VectorsTotal Test Cases✅ Passed❌ Failed⚠️ Skipped
10101000
✅ All test vectors passed
Automatically generated at: 2024-08-27T20:43:44.724Z

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 86.36364% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@6f72cd5). Learn more about missing BASE report.

Files Patch % Lines
Sources/tbDEX/Common/JSON/tbDEXJSONDecoder.swift 20.00% 4 Missing ⚠️
...ts/tbDEXTestVectors/tbDEXTestVectorsProtocol.swift 88.88% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage        ?   93.59%           
=======================================
  Files           ?       36           
  Lines           ?     1374           
  Branches        ?        0           
=======================================
  Hits            ?     1286           
  Misses          ?       88           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ethanwlee ethanwlee merged commit 7d7e6d5 into main Aug 28, 2024
1 check passed
@ethanwlee ethanwlee deleted the update-test-vectors branch August 28, 2024 17:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants