Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Remove web5 shim #115

Merged
merged 4 commits into from
Sep 4, 2024
Merged

Remove web5 shim #115

merged 4 commits into from
Sep 4, 2024

Conversation

KendallWeihe
Copy link
Contributor

No description provided.

@KendallWeihe
Copy link
Contributor Author

KendallWeihe commented Sep 4, 2024 •
edited
Loading

TODO: before merging I want to add the latest snapshot to the example app

Done

@KendallWeihe KendallWeihe marked this pull request as draft September 4, 2024 21:14
@KendallWeihe
Copy link
Contributor Author

KendallWeihe commented Sep 4, 2024 •
edited
Loading

once this is merged the test vectors ci job should be fixed

Done

KendallWeihe
KendallWeihe commented Sep 4, 2024
View reviewed changes
bound/kt/pom.xml
@@ -102,6 +102,7 @@
<version.com.fasterxml.jackson>2.17.0</version.com.fasterxml.jackson>
<version.net.java.dev.jna>5.12.0</version.net.java.dev.jna>
<version.org.jetbrains.kotlinx.kotlinx.coroutines.core>1.8.1</version.org.jetbrains.kotlinx.kotlinx.coroutines.core>
<version.xyz.block.web5>commit-f28d90c-SNAPSHOT</version.xyz.block.web5>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is currently using a snapshot build, but that's because we don't have an official web5-kt release yet -- will follow up with the official release once its available

@KendallWeihe KendallWeihe marked this pull request as ready for review September 4, 2024 21:44
@KendallWeihe KendallWeihe merged commit bb46a93 into main Sep 4, 2024
13 checks passed
@KendallWeihe KendallWeihe deleted the kendall/web5-shim branch September 4, 2024 22:07
@KendallWeihe KendallWeihe mentioned this pull request Sep 5, 2024
Closed
41 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitro-neal nitro-neal nitro-neal approved these changes

@kirahsapong kirahsapong Awaiting requested review from kirahsapong

@shamilovtim shamilovtim Awaiting requested review from shamilovtim

@diehuxx diehuxx Awaiting requested review from diehuxx

@decentralgabe decentralgabe Awaiting requested review from decentralgabe

@frankhinek frankhinek Awaiting requested review from frankhinek frankhinek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KendallWeihe @nitro-neal