-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
Enables License and other checks
|
TBDocs Report ✅ No errors or warnings @tbdex/protocol
@tbdex/http-client
@tbdex/http-server
TBDocs Report Updated at 2024-01-22T22:54:53Z |
yo @ALRubinger , thanks for adding this! qq regarding: I imagine this will fix itself when we merge to main? |
security-events: write | ||
# Needed to publish results and get a badge (see publish_results below). | ||
id-token: write | ||
# Uncomment the permissions below if installing in a private repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can safely assume this'll always be public so we can delete these commented lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave 'em for documentation purposes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets do this soon
Yup, should. Merging to main will trigger the checks and publish them - right now the badge can't see prior published results. |
@ALRubinger merge away |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 74.61% 74.61%
=======================================
Files 18 18
Lines 981 981
Branches 82 82
=======================================
Hits 732 732
Misses 249 249
|
Enables License and other checks