Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Install OSSF Scorecard #66

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Install OSSF Scorecard #66

merged 3 commits into from
Jan 22, 2024

Conversation

ALRubinger
Copy link
Contributor

Enables License and other checks

Enables License and other checks
Copy link

changeset-bot bot commented Nov 9, 2023

⚠️ No Changeset found

Latest commit: d208d53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 9, 2023

TBDocs Report

✅ No errors or warnings

@tbdex/protocol

  • Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

  • Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

  • Project entry file: packages/http-server/src/main.ts

TBDocs Report Updated at 2024-01-22T22:54:53Z d208d53

@mistermoe
Copy link
Member

yo @ALRubinger , thanks for adding this!

qq regarding:

image

I imagine this will fix itself when we merge to main?

security-events: write
# Needed to publish results and get a badge (see publish_results below).
id-token: write
# Uncomment the permissions below if installing in a private repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can safely assume this'll always be public so we can delete these commented lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave 'em for documentation purposes.

Copy link
Contributor

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets do this soon

@ALRubinger
Copy link
Contributor Author

yo @ALRubinger , thanks for adding this!

qq regarding:

image I imagine this will fix itself when we merge to main?

Yup, should. Merging to main will trigger the checks and publish them - right now the badge can't see prior published results.

@mistermoe
Copy link
Member

@ALRubinger merge away

@leordev leordev mentioned this pull request Jan 22, 2024
@ALRubinger ALRubinger requested a review from diehuxx as a code owner January 22, 2024 22:51
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Merging #66 (d208d53) into main (ad48871) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files          18       18           
  Lines         981      981           
  Branches       82       82           
=======================================
  Hits          732      732           
  Misses        249      249           
Components Coverage Δ
protocol ∅ <ø> (∅)
http-client 82.02% <ø> (ø)
http-server 68.73% <ø> (ø)

@leordev leordev merged commit a41dec2 into main Jan 22, 2024
17 checks passed
@leordev leordev deleted the ossf-scorecard branch January 22, 2024 22:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants