Added OrderInstructions message #268
Conversation
thehenrytsai
requested review from
michaelneale,
mistermoe,
jiyoonie9,
KendallWeihe,
kirahsapong,
diehuxx and
nitro-neal
as code owners
🦋 Changeset detectedLatest commit: 5358454 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
TBDocs Report ✅ No errors or warnings @tbdex/protocol
@tbdex/http-client
@tbdex/http-server
TBDocs Report Updated at 2024-08-08T20:02:58Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 95.77% 95.88% +0.11%
==========================================
Files 42 43 +1
Lines 3528 3623 +95
Branches 387 395 +8
==========================================
+ Hits 3379 3474 +95
Misses 149 149
|
|
@thehenrytsai could you remove payment instructions from quote.data.payin and quote.data.payout? https://github.com/TBD54566975/tbdex/tree/main/specs/protocol#quote edit: nvm, already done in a previous PR! cad5c4e#diff-de1395c953d9e4e9cc2c952c4664703e1008d46b2d4aa9702adc0a6cadd39370L396 |
| @@ -16,12 +16,14 @@ export type CreateOrderOptions = { | |||
| */ | |||
| export class Order extends Message { | |||
| /** a set of valid Message kinds that can come after an order */ | |||
| readonly validNext = new Set<MessageKind>(['orderstatus']) | |||
| readonly validNext = new Set<MessageKind>(['orderinstructions']) | |||
There was a problem hiding this comment.
i have these in tbdex-go for order
// ValidNext returns the valid message kinds that can follow an order.
func ValidNext() []string {
return []string{orderstatus.Kind, closemsg.Kind, cancel.Kind}
}
| expect(exchange.orderInstructions).to.deep.eq(orderInstructions) | ||
| }) | ||
|
|
||
| it('cannot add Rfq, Quote, Order, OrderStatus, or Close after Order', async () => { |
There was a problem hiding this comment.
technically you should be able to add a close after an order
There was a problem hiding this comment.
Thanks, will update!
No description provided.