-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
|
TBDocs Report 🛑 Errors: 0 @tbdex/protocol
@tbdex/http-client
@tbdex/http-server
TBDocs Report Updated at 2024-06-14T02:14:07Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
===========================================
+ Coverage 83.50% 95.71% +12.21%
===========================================
Files 42 42
Lines 3547 3528 -19
Branches 289 387 +98
===========================================
+ Hits 2962 3377 +415
+ Misses 585 151 -434
|
fix for: #252 and fixes the build |
|
||
- name: Upload test results to update SDK reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are the consequences if we get rid of this step? i feel like either @leordev or @finn-tbd set this up for some dashboard view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i want to say it's related to this page https://tbd54566975.github.io/sdk-report-runner/ but could be totally wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah - would like their input, as not sure. Could convert it to XML another way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried updating to latest mocha and reporter, same issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be due to something other than the test runner. The test that flaky fails on CI and local seems to always be the one that parses in the test vector as JSON due to timeout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it is likely uncovering some other problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consequences of getting rid of this step are indeed related to that page. It will no longer be able to display information about the tbdex-js, and just fully removing these steps may fully break the compliance report runner until it's updated to stop checking tbdex-js.
closing this as it didn't really solve it. Trying this approach: |
may be a bad mocha test reporter