Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

try different test reporter #255

Closed
wants to merge 1 commit into from
Closed

try different test reporter #255

wants to merge 1 commit into from

Conversation

michaelneale
Copy link
Contributor

may be a bad mocha test reporter

Copy link

changeset-bot bot commented Jun 14, 2024

⚠️ No Changeset found

Latest commit: 5c0ca32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 3

@tbdex/protocol

  • Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

  • Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

  • Project entry file: packages/http-server/src/main.ts
📄 File: packages/http-server/src/http-server.ts
⚠️ extractor:ae-unresolved-link: The @link reference could not be resolved: The package "@tbdex/http-server" does not have an export "InMemoryOfferingsApi" #L49
⚠️ extractor:ae-unresolved-link: The @link reference could not be resolved: The package "@tbdex/http-server" does not have an export "InMemoryExchangesApi" #L49
⚠️ extractor:ae-unresolved-link: The @link reference could not be resolved: The package "@tbdex/http-server" does not have an export "InMemoryBalancesApi" #L49

TBDocs Report Updated at 2024-06-14T02:14:07Z 5c0ca32

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.71%. Comparing base (8d8f022) to head (5c0ca32).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #255       +/-   ##
===========================================
+ Coverage   83.50%   95.71%   +12.21%     
===========================================
  Files          42       42               
  Lines        3547     3528       -19     
  Branches      289      387       +98     
===========================================
+ Hits         2962     3377      +415     
+ Misses        585      151      -434     
Components Coverage Δ
protocol 94.90% <0.00%> (ø)
http-client 100.00% <ø> (ø)
http-server 94.65% <100.00%> (+46.25%) ⬆️

@michaelneale
Copy link
Contributor Author

fix for: #252 and fixes the build


- name: Upload test results to update SDK reports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the consequences if we get rid of this step? i feel like either @leordev or @finn-tbd set this up for some dashboard view

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to say it's related to this page https://tbd54566975.github.io/sdk-report-runner/ but could be totally wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - would like their input, as not sure. Could convert it to XML another way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried updating to latest mocha and reporter, same issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be due to something other than the test runner. The test that flaky fails on CI and local seems to always be the one that parses in the test vector as JSON due to timeout.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it is likely uncovering some other problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah just saw this locally:

image

So it isn't really a fix, just hiding some timeout.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consequences of getting rid of this step are indeed related to that page. It will no longer be able to display information about the tbdex-js, and just fully removing these steps may fully break the compliance report runner until it's updated to stop checking tbdex-js.

@michaelneale
Copy link
Contributor Author

I don't think this fixes it yet BTW< saw this locally:

image

@michaelneale
Copy link
Contributor Author

closing this as it didn't really solve it. Trying this approach:

#256

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants