-
Notifications
You must be signed in to change notification settings - Fork 55
SIP 2 - Create Credential Manifests CRUD #91
Conversation
@@ -24,6 +24,8 @@ require ( | |||
|
|||
require go.etcd.io/bbolt v1.3.6 | |||
|
|||
require github.com/oliveagle/jsonpath v0.0.0-20180606110733-2e52cf6e6852 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where I added this or used this? When I try to remove it brings it back when I mage build
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
- Coverage 26.63% 25.94% -0.69%
==========================================
Files 13 14 +1
Lines 751 844 +93
==========================================
+ Hits 200 219 +19
- Misses 521 594 +73
- Partials 30 31 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more thing - the config.toml
files should be updated to have a new manifest entry
// @Router /v1/manifests [get] | ||
func (cr ManifestRouter) GetManifests(ctx context.Context, w http.ResponseWriter, r *http.Request) error { | ||
gotManifests, err := cr.service.GetManifests() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do you handle the query parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Past the change to config.toml
, lgtm!
This is the implementation of the Credential Manifest CRUD functionality according to SIP 2
https://github.com/TBD54566975/ssi-service/tree/main/sip/sips/sip_2
Postman Datad
PUT Manifest
Input:
Output