Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

updated bolt dependency and fix issue #73 #74

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

andorsk
Copy link
Contributor

@andorsk andorsk commented Jul 28, 2022

related to issue #73. boltdb is not long maintained, and a race condition occurs on the old build. With this update, you can add -race condition to magefile.

Included in this PR is also an addition of adding a -race flag to the mage tests.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #74 (15511d4) into main (2e3fe79) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   26.63%   26.63%           
=======================================
  Files          13       13           
  Lines         751      751           
=======================================
  Hits          200      200           
  Misses        521      521           
  Partials       30       30           
Impacted Files Coverage Δ
pkg/storage/bolt.go 68.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e3fe79...15511d4. Read the comment docs.

@andorsk andorsk changed the title updated bolt dependency updated bolt dependency and fix issue #73 Jul 28, 2022
@decentralgabe
Copy link
Member

ah, I was avoiding updating because I thought bolt was stable!
I did try to debug this race condition issue for a few hours the other day and couldn't figure it out.
If the new lib fixes it, it's a good reason to update 😄
thanks @andorsk !

@decentralgabe decentralgabe merged commit 935b762 into TBD54566975:main Jul 28, 2022
@andorsk andorsk deleted the update-bolt branch July 28, 2022 17:35
@andorsk
Copy link
Contributor Author

andorsk commented Jul 28, 2022

@decentralgabe gracias! 🙇

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants