-
Notifications
You must be signed in to change notification settings - Fork 55
Add Support for OpenTelemetry #60
Add Support for OpenTelemetry #60
Conversation
Thank you @atsushii for your contribution. I sent a number of requests to the service while jager was running, but wasn't able to see the traces come through. I'm not familiar with OpenTelemetry so won't be of much use to you here. Before merging, I think it's valuable to see traces for all requests that come into the service. |
@decentralgabe |
@atsushii I've tried reloading the browser. I even tried using multiple browsers (Safari, Chrome) after sending requests. Still don't see the SSI service show up. |
@decentralgabe I've deleted containers, images, and volumes before starting a new container then still it works. |
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 26.13% 26.13%
=======================================
Files 13 13
Lines 746 746
=======================================
Hits 195 195
Misses 521 521
Partials 30 30 Continue to review full report at Codecov.
|
Removed all containers and did a fresh checkout. Worked! |
Addresses #31
What I did
Added support for OpenTelemetry (https://opentelemetry.io/docs/instrumentation/go/getting-started/)
Please check the browser data on Jaeger
step
1, mage run
2, send a request e.g. curl http://localhost:8080/health
3, open the Jaeger UI (http://localhost:16686/)