Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Add Support for OpenTelemetry #60

Merged

Conversation

atsushii
Copy link
Contributor

Addresses #31

What I did

Added support for OpenTelemetry (https://opentelemetry.io/docs/instrumentation/go/getting-started/)

Please check the browser data on Jaeger

step

1, mage run
2, send a request e.g. curl http://localhost:8080/health
3, open the Jaeger UI (http://localhost:16686/)

@decentralgabe
Copy link
Member

Thank you @atsushii for your contribution. I sent a number of requests to the service while jager was running, but wasn't able to see the traces come through. I'm not familiar with OpenTelemetry so won't be of much use to you here.

Before merging, I think it's valuable to see traces for all requests that come into the service.

In this UI, I see only the jager service show up:
Screen Shot 2022-07-19 at 2 53 49 PM

@atsushii
Copy link
Contributor Author

@decentralgabe
Did you reload the browser after sending the request? (I missed telling it..)
After reloading the browser, you can see the service like below!

Screen Shot 2022-07-20 at 9 07 44 AM

@decentralgabe
Copy link
Member

@atsushii I've tried reloading the browser. I even tried using multiple browsers (Safari, Chrome) after sending requests. Still don't see the SSI service show up.

@atsushii
Copy link
Contributor Author

@decentralgabe
Thank you for trying!

I've deleted containers, images, and volumes before starting a new container then still it works.
I am not really sure why you can not see the SSI service but can you plz try to rebuild the container after deleting all related images, containers, and volumes if it is possible.😅

@codecov-commenter
Copy link

Codecov Report

Merging #60 (1e763d6) into main (c06bae1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   26.13%   26.13%           
=======================================
  Files          13       13           
  Lines         746      746           
=======================================
  Hits          195      195           
  Misses        521      521           
  Partials       30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c06bae1...1e763d6. Read the comment docs.

@decentralgabe
Copy link
Member

Removed all containers and did a fresh checkout. Worked!

@decentralgabe decentralgabe merged commit c0ed1c0 into TBD54566975:main Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants