Fixing Cred Suspension Bug #487
Conversation
Codecov Report
@@ Coverage Diff @@
## main #487 +/- ##
==========================================
- Coverage 20.62% 20.56% -0.06%
==========================================
Files 48 48
Lines 5756 5772 +16
==========================================
Hits 1187 1187
- Misses 4360 4376 +16
Partials 209 209
|
|
Fixes - #473 |
integration/common.go
Outdated
| func CreateVerifiableCredential(credentialInput credInputParams, revocable bool) (string, error) { | ||
| func CreateVerifiableCredential(credentialInput credInputParams) (string, error) { | ||
| return CreateVerifiableCredentialWithStatus(credentialInput, false, false) | ||
| } |
|
|
||
| func TestSuspensionCreateIssuerDIDKeyIntegration(t *testing.T) { | ||
| if testing.Short() { | ||
| t.Skip("skipping integration testz") |
| @@ -0,0 +1,233 @@ | |||
| package integration | |||
There was a problem hiding this comment.
could this be combined into a credential_status_integration_test?
There was a problem hiding this comment.
it could be, but I opted for a fresh flow, fresh creds, making sure suspension works, didnt want like a revokable cred flow to 'init' something so a suspension would work
There was a problem hiding this comment.
I'm worried about scaling this once we move to a generic status - and not needing to support specific statuses. But fine to save that until we impl that change.
| "postalCode": "78724", | ||
| "streetAddress": "123 Janktopia Ave." | ||
| }, | ||
| "taxID":"123" |
There was a problem hiding this comment.
| "taxID":"123" | |
| "taxId":"123" |
integration/common.go
Outdated
| @@ -124,6 +128,10 @@ func CreateVerifiableCredential(credentialInput credInputParams, revocable bool) | |||
| if revocable { | |||
| fileName = "credential-revocable-input.json" | |||
| } | |||
| if suspendable { | |||
| fileName = "credential-suspendable-input.json" | |||
There was a problem hiding this comment.
Maybe worth putting them in the same json and using the templating mechanism?
There was a problem hiding this comment.
Added 👍 and removed these .json files
Fixed the suspension issue not reflecting back to the user.
Updated unit tests
Created suspension integration test
Added UnRevoke and UnSuspend integration test