This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Added JWT for definitions. #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresuribe87
requested review from
decentralgabe and
nitro-neal
as code owners
Codecov Report
@@ Coverage Diff @@
## main #262 +/- ##
==========================================
- Coverage 24.87% 24.67% -0.21%
==========================================
Files 31 31
Lines 3063 3084 +21
==========================================
- Hits 762 761 -1
- Misses 2184 2206 +22
Partials 117 117
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| @@ -2,12 +2,18 @@ package router | |||
|
|
|||
| import ( | |||
| "context" | |||
| crypto2 "crypto" | |||
There was a problem hiding this comment.
nit: rename alias to gocrypto or similar
pkg/service/presentation/service.go
Outdated
| return &model.CreatePresentationDefinitionResponse{ | ||
| PresentationDefinition: storedPresentation.PresentationDefinition, | ||
| }, nil | ||
| m := &model.CreatePresentationDefinitionResponse{} |
There was a problem hiding this comment.
either
var m model.CreatePresentationDefinitionResponse
or
m := new(model.CreatePresentationDefinitionResponse)
decentralgabe
approved these changes
Jan 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds JWTs for presentation definitions. This means that it is the implementation for presentation request.
Description
A couple of changes happened with this PR.
Author, was introduced for creating presentation definitions.How Has This Been Tested?
Unit tests were updated, as well as integration tests.