This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Added manual overrides for credential issuance upon application review. #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresuribe87
requested review from
decentralgabe and
nitro-neal
as code owners
| @@ -98,6 +100,7 @@ func (s Service) buildCredentialResponse( | |||
| return nil, nil, err | |||
| } | |||
| } | |||
| s.applyRequestData(&credentialRequest, credentialOverrides, od) | |||
There was a problem hiding this comment.
methods without return values make me nervous!
decentralgabe
approved these changes
Jan 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When a review happens, the issuer admin might want to override some values that will be put in the credentials that will be produced.
Description
This PR changes. Noteworthy: using a map instead of a list for the overrides. This is because the order of the overrides doesn't matter.
How Has This Been Tested?
Added overrides for a credential in existing tests. Additionally modified the e2e tests.
References
Still part of SIP5