Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

ctx for db write #246

Merged
merged 5 commits into from
Jan 10, 2023
Merged

ctx for db write #246

merged 5 commits into from
Jan 10, 2023

Conversation

nitro-neal
Copy link
Contributor

Overview

Adding context to database impl

Description

This change adds the api level context and passes wires it up to the db Write functionality.

The context object from the http request includes information about the client making the request and will end if the client disconnects before the request is finished.

@decentralgabe
Copy link
Member

looks like a few more method calls need ctx added as arguments

@nitro-neal
Copy link
Contributor Author

yea I should have put this up as a draft, just did a write to make sure this was the way we wanted to do it.

@nitro-neal
Copy link
Contributor Author

will implement the rest of the db interface methods now and update unit tests

@codecov-commenter
Copy link

Codecov Report

Merging #246 (1762502) into main (d0dde58) will decrease coverage by 0.00%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   25.18%   25.17%   -0.01%     
==========================================
  Files          31       31              
  Lines        3022     3023       +1     
==========================================
  Hits          761      761              
- Misses       2144     2145       +1     
  Partials      117      117              
Impacted Files Coverage Δ
pkg/server/router/credential.go 3.57% <0.00%> (ø)
pkg/server/router/did.go 7.92% <0.00%> (ø)
pkg/server/router/issuance.go 0.00% <0.00%> (ø)
pkg/server/router/keystore.go 12.69% <0.00%> (ø)
pkg/server/router/manifest.go 9.81% <0.00%> (ø)
pkg/server/router/operation.go 0.00% <0.00%> (ø)
pkg/server/router/presentation.go 3.65% <0.00%> (ø)
pkg/server/router/schema.go 9.19% <0.00%> (ø)
pkg/service/operation/service.go 0.00% <0.00%> (ø)
pkg/storage/storage.go 40.62% <ø> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nitro-neal nitro-neal merged commit 82a6233 into main Jan 10, 2023
@nitro-neal nitro-neal deleted the context-for-db-ose-302 branch January 10, 2023 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants