This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
[OSE-300] Credential applications can be cancelled #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 25.93% 24.90% -1.03%
==========================================
Files 28 31 +3
Lines 2738 2919 +181
==========================================
+ Hits 710 727 +17
- Misses 1911 2074 +163
- Partials 117 118 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
andresuribe87
requested review from
decentralgabe and
nitro-neal
as code owners
| @@ -30,6 +31,8 @@ type StoredManifest struct { | |||
|
|
|||
| type StoredApplication struct { | |||
| ID string `json:"id"` | |||
| Status credential.Status `json:"status"` | |||
| Reason string `json:"reason"` | |||
There was a problem hiding this comment.
should this be an enum or user defined?
There was a problem hiding this comment.
I'm imagining it's user defined free form text. We can change later once we see real use cases.
decentralgabe
approved these changes
Jan 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After a credential application is submitted, an operation is returned. This PR adds the ability to cancel the operation related to that application.
Description
All operations can be cancelled, as long as they aren't marked as done.
How Has This Been Tested?
Added a simple unit test to the service endpoint.
Checklist
Before submitting this PR, please make sure: