This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
[OSE-170][OSE-169] Create Submission Implementation #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The simplest scaffolding possible * rename Co-authored-by: Gabe <[email protected]>
andresuribe87
force-pushed
the
ose-170-create-submission-impl
branch
from
c003c51 to
318ae8d
Compare
andresuribe87
changed the title
andresuribe87
commented
Nov 29, 2022
Comment on lines
+72
to
+79
| parsed, parseErr := jwk.ParseKey(jwkBytes) | ||
| if parseErr != nil { | ||
| err = parseErr | ||
| return | ||
| } | ||
| if err = parsed.Raw(&pubKey); err != nil { | ||
| return | ||
| } |
There was a problem hiding this comment.
Across the board, we expect crypto.PublicKey to be a type from go's crypto package. This new bit of code ensure's that's the case.
andresuribe87
requested review from
decentralgabe and
nitro-neal
as code owners
There was a problem hiding this comment.
may want to uptake the latest sdk that was just merged, commit here - TBD54566975/ssi-sdk@92be548
| if err := s.verifier.VerifyJWTCredential(*cred.CredentialJWT); err != nil { | ||
| return nil, errors.Wrapf(err, "verifying jwt credential %s", cred.CredentialJWT) | ||
| } | ||
| } else { |
There was a problem hiding this comment.
can get rid of this else here and have the same behavior
There was a problem hiding this comment.
Thanks for the suggestion! I'm keeping since cred might have both CredentialJWT and Credential populated, so having the else would avoid doing double validation in that case.
decentralgabe
approved these changes
Nov 29, 2022
| return nil, errors.Wrapf(err, "verifying jwt credential %s", cred.CredentialJWT) | ||
| } | ||
| } else { | ||
| if cred.Credential != nil && cred.Credential.Proof != nil { |
There was a problem hiding this comment.
this can be cred.HasDataIntegrityCredential()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jwt.ServiceStorageinterface.ErrSubmissionNotFounderror type.Operationobjects.