Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

DID API #17

Merged
merged 24 commits into from
Apr 3, 2022
Merged

DID API #17

merged 24 commits into from
Apr 3, 2022

Conversation

decentralgabe
Copy link
Member

Service shuffling. DID API support

@decentralgabe decentralgabe marked this pull request as ready for review April 1, 2022 22:54
@decentralgabe decentralgabe requested a review from mistermoe as a code owner April 1, 2022 22:54
Copy link
Member

@mistermoe mistermoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the overall pattern makes sense to me. Naming is throwing me off a bit. Naming is always subjective and words are hard. Here’s my opinion though:

The VC Service contains services it seems. one of which will likely be a VC service. which makes things complicated to grok. Specifically this. I almost wonder if it’d make more sense if the VC Service was a collection of APIs (DID API, VC API etc.)

and I wonder if the VC Service should be called the SSI service. which exposes APIs like the VC API, DID API etc.

Super curious to hear your thoughts. This almost makes me wonder, if you're on board with SSI service, do we change did-sdk -> ssi-sdk 🤔

@decentralgabe
Copy link
Member Author

the overall pattern makes sense to me. Naming is throwing me off a bit. Naming is always subjective and words are hard. Here’s my opinion though:

The VC Service contains services it seems. one of which will likely be a VC service. which makes things complicated to grok. Specifically this. I almost wonder if it’d make more sense if the VC Service was a collection of APIs (DID API, VC API etc.)

and I wonder if the VC Service should be called the SSI service. which exposes APIs like the VC API, DID API etc.

Super curious to hear your thoughts. This almost makes me wonder, if you're on board with SSI service, do we change did-sdk -> ssi-sdk 🤔

They should be consistent, I agree. The scope of the DID SDK is larger than DIDs, and the scope of the VC Service is larger than VCS. I agree with ssi-sdk and ssi-service; its less ambiguous than "DID" meaning "decentralized identity" over "decentralized identifiers".

@decentralgabe
Copy link
Member Author

will handle renaming now, tests in the next PR

@decentralgabe decentralgabe merged commit f4f5ee2 into main Apr 3, 2022
@decentralgabe decentralgabe deleted the did-api branch April 3, 2022 17:25
@decentralgabe decentralgabe mentioned this pull request Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants