-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the overall pattern makes sense to me. Naming is throwing me off a bit. Naming is always subjective and words are hard. Here’s my opinion though:
The VC Service contains services it seems. one of which will likely be a VC service. which makes things complicated to grok. Specifically this. I almost wonder if it’d make more sense if the VC Service was a collection of APIs (DID API, VC API etc.)
and I wonder if the VC Service should be called the SSI service. which exposes APIs like the VC API, DID API etc.
Super curious to hear your thoughts. This almost makes me wonder, if you're on board with SSI service, do we change did-sdk
-> ssi-sdk
🤔
They should be consistent, I agree. The scope of the DID SDK is larger than DIDs, and the scope of the VC Service is larger than VCS. I agree with |
will handle renaming now, tests in the next PR |
Service shuffling. DID API support