This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Enabled golangci-lint with staticcheck only and fixed issues #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresuribe87
requested review from
decentralgabe and
nitro-neal
as code owners
Codecov Report
@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 27.79% 27.79%
=======================================
Files 20 20
Lines 1558 1558
=======================================
Hits 433 433
Misses 1051 1051
Partials 74 74
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
decentralgabe
suggested changes
Oct 28, 2022
pkg/server/router/dwn.go
Outdated
| Manifest manifest.CredentialManifest `json:"manifest" validate:"required"` | ||
| DWNResponse dwnpkg.DWNPublishManifestResponse `json:"dwnResponse" validate:"required"` | ||
| Manifest *manifest.CredentialManifest `json:"manifest" validate:"required"` | ||
| DWNResponse *dwnpkg.DWNPublishManifestResponse `json:"dwnResponse" validate:"required"` |
There was a problem hiding this comment.
i'd prefer reverting this, required fields should not be nil-able
pkg/server/router/dwn.go
Outdated
| @@ -79,20 +79,20 @@ func (dwnr DWNRouter) PublishManifest(ctx context.Context, w http.ResponseWriter | |||
| req := request.ToServiceRequest() | |||
| publishManifestResponse, err := dwnr.service.GetManifest(req) | |||
|
|
|||
| if err != nil || &publishManifestResponse.Manifest == nil { | |||
| if err != nil || publishManifestResponse.Manifest == nil { | |||
There was a problem hiding this comment.
to get around this check we should define an IsEmpty method on Manifest. I think one may even already exist.
decentralgabe
approved these changes
Oct 28, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures and enables golangci-lint in github actions. I intentionally only enabled the
staticchecklinter, so this becomes easier to review. The only noteworthy change to highlight was the due to the following warning:To fix, I changed this to use the
IsEmpty()method.Additional linters will be enabled in a follow up PR.