This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
adding cm ca validation #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 12, 2022 16:25
| @@ -136,11 +136,19 @@ func (s Service) ProcessApplicationSubmission(request SubmitApplicationRequest) | |||
| return nil, util.LoggingErrorMsg(err, "problem with retrieving manifest during application validation") | |||
| } | |||
|
|
|||
| if gotManifest == nil { | |||
| return nil, util.LoggingNewError(fmt.Sprintf("application is not valid. A manifest does not exist with id: %s", credApp.ManifestID)) | |||
There was a problem hiding this comment.
maybe break this into two lines for readability
decentralgabe
approved these changes
Oct 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 28.00% 28.00%
=======================================
Files 20 20
Lines 1475 1475
=======================================
Hits 413 413
Misses 995 995
Partials 67 67
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change adds cred application and cred manifest validation against eachother (pulled in from sdk)