This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Schema Signing & Verification #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
decentralgabe
commented
Oct 10, 2022
decentralgabe
commented
- schema signing, verification functionality + APIs
- added delete schema apis
- tests for all
- not yet integrated into credential creation code
decentralgabe
commented
Oct 10, 2022
| @@ -0,0 +1,108 @@ | |||
| package keyaccess | |||
There was a problem hiding this comment.
moved this to its own package, since it has use outside of just cred verification
added 2 commits
October 10, 2022 16:58
nitro-neal
reviewed
Oct 11, 2022
| @@ -87,8 +87,15 @@ func (dr DIDRouter) CreateDIDByMethod(ctx context.Context, w http.ResponseWriter | |||
| } | |||
|
|
|||
| var request CreateDIDByMethodRequest | |||
| invalidCreateDIDRequest := "invalid create DID request" | |||
| if err := framework.Decode(r, &request); err != nil { | |||
There was a problem hiding this comment.
alternativly you could do
if framework.Decode(r, &request) != nil || framework.ValidateRequest(request) != nil {
errMsg := invalidCreateDIDRequest
logrus.WithError(err).Error(errMsg)
return framework.NewRequestError(errors.Wrap(err, errMsg), http.StatusBadRequest)
}
since its the same output (but you need to get err variable in a golang way somehow lol maybe not possible)
There was a problem hiding this comment.
yeah, unfortunately this wouldn't work because both return unique errors and we couldn't capture both. conditional error assignment would be a nice feature 🤔
nitro-neal
approved these changes
Oct 11, 2022
This was referenced Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.