This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
have dwn go through the svc endpoint #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 28.20% 28.20%
=======================================
Files 18 18
Lines 1202 1202
=======================================
Hits 339 339
Misses 815 815
Partials 48 48 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nitro-neal
reviewed
Sep 29, 2022
| logrus.Debugf("getting manifest: %s", request.ManifestID) | ||
|
|
||
| gotManifest, err := s.manifestStorage.GetManifest(request.ManifestID) | ||
| gotManifest, err := s.manifest.GetManifest(manifest.GetManifestRequest{ID: request.ManifestID}) |
There was a problem hiding this comment.
Yup this is exactly what I was thinking about doing for a clean up 2nd pass.
We can even delete the dwn/model.go file and use CreateManifestRequest in manifest too, but that may be too much mixing
nitro-neal
approved these changes
Sep 29, 2022
decentralgabe
pushed a commit
that referenced
this pull request
Sep 30, 2022
…of-signing-ose-101 * origin/main: have dwn go through the svc endpoint (#115)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should have caught this earlier. really we should think of the 'service' apis as all that are exposed to other services. storage should be internal to each service