This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
SIP-4: DWN Routes #113
Merged
SIP-4: DWN Routes #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2022 14:10
Codecov Report
@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 27.76% 27.69% -0.07%
==========================================
Files 16 17 +1
Lines 1059 1123 +64
==========================================
+ Hits 294 311 +17
- Misses 723 769 +46
- Partials 42 43 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
decentralgabe
suggested changes
Sep 27, 2022
pkg/server/framework/request.go
Outdated
|
|
||
| resp, err := http.Post(endpoint, "application/json", bytes.NewBuffer(jsonData)) | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
here too - what kind of error would be returned to the client and logged to us?
pkg/server/router/dwn.go
Outdated
| return framework.NewRequestError(errors.Wrap(err, errMsg), http.StatusBadRequest) | ||
| } | ||
|
|
||
| status := dwnResp.StatusCode >= 200 && dwnResp.StatusCode < 300 |
There was a problem hiding this comment.
status is a binary value?
|
|
||
| if err != nil { | ||
| errMsg := "could not publish manifest to dwn" | ||
| if err != nil || &publishManifestResponse.Manifest == nil { |
There was a problem hiding this comment.
consider an IsEmpty method on publishManifestResponse
decentralgabe
approved these changes
Sep 27, 2022
nitro-neal
deleted the
sip-4-create-a-new-package-boilerplate-ose-115
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New DWN route for publishing a manifest, with dwn config for dwn endpoint
Input:
{{baseUrl}}/v1/dwn/manifests
Output