Enabled more linters (#150)

* Enabled golangci-lint with staticcheck only and fixed issues

* Reverted extra file and added todo

* Remove the noise

* Added more linters plus fixes

* Tidying up

* undo extra stuff

.golangci.yaml

@@ -10,8 +10,15 @@ output:
 linters:
   disable-all: true
   enable:
-# TODO(Andres): enable the linters specified below.
-#    - revive
-#    - gosec
-#    - govet
+    - revive
+    - gosec
+    - govet
     - staticcheck
+
+linters-settings:
+  gosec:
+    config:
+      G101:
+        # We intentionally remove the 'cred' regex, to avoid false positives
+        pattern: "(/i)passwd|pass|password|pwd|secret|token|pw|apiKey|bearer"
+

pkg/dwn/dwn.go

@@ -9,19 +9,19 @@ import (
 	"net/http"
 )
 
-type DWNPublishManifestRequest struct {
+type PublishManifestRequest struct {
 	Manifest manifest.CredentialManifest `json:"manifest" validate:"required"`
 }
 
-type DWNPublishManifestResponse struct {
+type PublishManifestResponse struct {
 	Status   int    `json:"status" validate:"required"`
 	Response string `json:"response" validate:"required"`
 }
 
 // PublishManifest publishes a CredentialManifest to a DWN
-func PublishManifest(endpoint string, manifest manifest.CredentialManifest) (*DWNPublishManifestResponse, error) {
+func PublishManifest(endpoint string, manifest manifest.CredentialManifest) (*PublishManifestResponse, error) {
 
-	dwnReq := DWNPublishManifestRequest{Manifest: manifest}
+	dwnReq := PublishManifestRequest{Manifest: manifest}
 	postResp, err := Post(endpoint, dwnReq)
 
 	if err != nil {
@@ -33,7 +33,7 @@ func PublishManifest(endpoint string, manifest manifest.CredentialManifest) (*DW
 	b, _ := io.ReadAll(postResp.Body)
 	body := string(b)
 
-	return &DWNPublishManifestResponse{Status: postResp.StatusCode, Response: body}, nil
+	return &PublishManifestResponse{Status: postResp.StatusCode, Response: body}, nil
 
 }
 
@@ -45,6 +45,7 @@ func Post(endpoint string, data interface{}) (*http.Response, error) {
 		return nil, err
 	}
 
+	// #nosec: we are assuming the endpoint is safe. We might want to revisit.
 	resp, err := http.Post(endpoint, "application/json", bytes.NewBuffer(jsonData))
 
 	if err != nil {

pkg/server/router/credential.go

@@ -228,18 +228,18 @@ func (cr CredentialRouter) GetCredentials(ctx context.Context, w http.ResponseWr
 	}
 
 	if issuer != nil {
-		return cr.getCredentialsByIssuer(*issuer, ctx, w, r)
+		return cr.getCredentialsByIssuer(ctx, *issuer, w, r)
 	}
 	if subject != nil {
-		return cr.getCredentialsBySubject(*subject, ctx, w, r)
+		return cr.getCredentialsBySubject(ctx, *subject, w, r)
 	}
 	if schema != nil {
-		return cr.getCredentialsBySchema(*schema, ctx, w, r)
+		return cr.getCredentialsBySchema(ctx, *schema, w, r)
 	}
 	return err
 }
 
-func (cr CredentialRouter) getCredentialsByIssuer(issuer string, ctx context.Context, w http.ResponseWriter, _ *http.Request) error {
+func (cr CredentialRouter) getCredentialsByIssuer(ctx context.Context, issuer string, w http.ResponseWriter, _ *http.Request) error {
 	gotCredentials, err := cr.service.GetCredentialsByIssuer(credential.GetCredentialByIssuerRequest{Issuer: issuer})
 	if err != nil {
 		errMsg := fmt.Sprintf("could not get credentials for issuer: %s", util.SanitizeLog(issuer))
@@ -251,7 +251,7 @@ func (cr CredentialRouter) getCredentialsByIssuer(issuer string, ctx context.Con
 	return framework.Respond(ctx, w, resp, http.StatusOK)
 }
 
-func (cr CredentialRouter) getCredentialsBySubject(subject string, ctx context.Context, w http.ResponseWriter, _ *http.Request) error {
+func (cr CredentialRouter) getCredentialsBySubject(ctx context.Context, subject string, w http.ResponseWriter, _ *http.Request) error {
 	gotCredentials, err := cr.service.GetCredentialsBySubject(credential.GetCredentialBySubjectRequest{Subject: subject})
 	if err != nil {
 		errMsg := fmt.Sprintf("could not get credentials for subject: %s", util.SanitizeLog(subject))
@@ -263,7 +263,7 @@ func (cr CredentialRouter) getCredentialsBySubject(subject string, ctx context.C
 	return framework.Respond(ctx, w, resp, http.StatusOK)
 }
 
-func (cr CredentialRouter) getCredentialsBySchema(schema string, ctx context.Context, w http.ResponseWriter, _ *http.Request) error {
+func (cr CredentialRouter) getCredentialsBySchema(ctx context.Context, schema string, w http.ResponseWriter, _ *http.Request) error {
 	gotCredentials, err := cr.service.GetCredentialsBySchema(credential.GetCredentialBySchemaRequest{Schema: schema})
 	if err != nil {
 		errMsg := fmt.Sprintf("could not get credentials for schema: %s", util.SanitizeLog(schema))

pkg/server/router/dwn.go

@@ -46,8 +46,8 @@ func (req PublishManifestRequest) ToServiceRequest() dwn.PublishManifestRequest
 }
 
 type PublishManifestResponse struct {
-	Manifest    manifest.CredentialManifest       `json:"manifest" validate:"required"`
-	DWNResponse dwnpkg.DWNPublishManifestResponse `json:"dwnResponse" validate:"required"`
+	Manifest    manifest.CredentialManifest    `json:"manifest" validate:"required"`
+	DWNResponse dwnpkg.PublishManifestResponse `json:"dwnResponse" validate:"required"`
 }
 
 // PublishManifest godoc

pkg/storage/bolt_test.go

@@ -125,7 +125,7 @@ func TestBoltDBPrefixAndKeys(t *testing.T) {
 	assert.Len(t, prefixValues, 2)
 
 	var keys []string
-	for k, _ := range prefixValues {
+	for k := range prefixValues {
 		keys = append(keys, k)
 	}
 	assert.Contains(t, keys, "bitcoin-testnet")

test/steelthread.go

@@ -189,7 +189,7 @@ func getJSONElement(jsonString string, jsonPath string) (string, error) {
 func get(url string) (string, error) {
 	fmt.Printf("\nPerforming GET request to:  %s\n", url)
 
-	resp, err := http.Get(url)
+	resp, err := http.Get(url) // #nosec: testing only.
 	if err != nil {
 		return "", errors.Wrap(err, "problem with finding element in json string")
 	}