Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Rename schema file #39

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Rename schema file #39

merged 1 commit into from
Jul 12, 2024

Conversation

frankhinek
Copy link
Contributor

Context: TBD Schema Hosting

This PR will:

  • Rename kcc-schema.json to kcc.schema.json to match the naming convention of other TBD schema files.

closes #38

Signed-off-by: Frank Hinek <[email protected]>
Copy link
Contributor

@tomdaffurn tomdaffurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not moving the schema file to another repo? Or are we linking?

@frankhinek
Copy link
Contributor Author

frankhinek commented Jul 12, 2024

Are we not moving the schema file to another repo? Or are we linking?

@tomdaffurn Based on the comments from @mistermoe and @decentralgabe in the proposal thread, I was planning to leave the tbDEX and KCC schemas with their respective spec repos. These will be submodules in the schemas repo to publish all of the schemas regardless of the "source of truth."

Tradeoffs to each approach, but this might make it easier to have a common https://hosted.schemas/... path for our schemas regardless of which repo they live in or if they move in the future.

But still a work in progress, so definitely open to alternative approaches if you think there might be a better way.

@tomdaffurn
Copy link
Contributor

Are we not moving the schema file to another repo? Or are we linking?

@tomdaffurn Based on the comments from @mistermoe and @decentralgabe in the proposal thread, I was planning to leave the tbDEX and KCC schemas with their respective spec repos. These will be submodules in the schemas repo to publish all of the schemas regardless of the "source of truth."

Tradeoffs to each approach, but this might make it easier to have a common https://hosted.schemas/... path for our schemas regardless of which repo they live in or if they move in the future.

But still a work in progress, so definitely open to alternative approaches if you think there might be a better way.

Thanks @frankhinek. Sounds good

@frankhinek frankhinek merged commit f3a1089 into main Jul 12, 2024
@frankhinek frankhinek deleted the rename-kcc-schema branch July 12, 2024 00:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename schemas file to match convention
2 participants