feat: add python runtime and plugin #3181
Merged
+841
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt2e
reviewed
Oct 24, 2024
| @@ -103,7 +103,7 @@ func generateStubsForEachLanguage(ctx context.Context, projectRoot string, modul | |||
| } | |||
| err := wg.Wait() | |||
| if err != nil { | |||
| return fmt.Errorf("failed to generate go stubs: %w", err) | |||
| return fmt.Errorf("failed to generate language stubs: %w", err) | |||
matt2e
approved these changes
Oct 24, 2024
wesbillman
force-pushed
the
add-python-runtime-and-plugin
branch
from
3447cbb
to
036fc20
Compare
worstell
force-pushed
the
add-python-runtime-and-plugin
branch
from
c5bc937
to
1023df3
Compare
mistermoe
approved these changes
Oct 24, 2024
worstell
force-pushed
the
add-python-runtime-and-plugin
branch
from
37c6b67
to
ce1d013
Compare
wesbillman
force-pushed
the
add-python-runtime-and-plugin
branch
from
ce1d013
to
68e3158
Compare
worstell
force-pushed
the
add-python-runtime-and-plugin
branch
from
68e3158
to
adc1285
Compare
wesbillman
force-pushed
the
add-python-runtime-and-plugin
branch
3 times, most recently
from
dd4fb2d
to
dcedd97
Compare
wesbillman
force-pushed
the
add-python-runtime-and-plugin
branch
from
8c5c832
to
b925d23
Compare
alecthomas
approved these changes
Oct 25, 2024
| @@ -0,0 +1,58 @@ | |||
| package main | |||
There was a problem hiding this comment.
This should be in python-runtime/cmd/ftl-language-python/main.go
Comment on lines
+34
to
+57
| logger.Infof("ftl-language-python starting up") | ||
|
|
||
| // Handle signals. | ||
| sigch := make(chan os.Signal, 1) | ||
| signal.Notify(sigch, syscall.SIGINT, syscall.SIGTERM) | ||
| go func() { | ||
| sig := <-sigch | ||
| logger.Debugf("ftl-language-python terminating with signal %s", sig) | ||
| cancel() | ||
| _ = syscall.Kill(-syscall.Getpid(), sig.(syscall.Signal)) //nolint:forcetypeassert,errcheck // best effort | ||
| os.Exit(0) | ||
| }() | ||
|
|
||
| kctx.BindTo(ctx, (*context.Context)(nil)) | ||
|
|
||
| svc := pythonplugin.New() | ||
| logger.Infof("ftl-language-python starting to serve on %v", cli.Bind) | ||
| err := rpc.Serve(ctx, | ||
| cli.Bind, | ||
| rpc.GRPC(languagepbconnect.NewLanguageServiceHandler, svc), | ||
| rpc.PProf(), | ||
| ) | ||
| logger.Errorf(err, "ftl-language-python stopped serving") | ||
| kctx.FatalIfErrorf(err) |
There was a problem hiding this comment.
This should be using internal/plugin.Start(), which handles all this for you automatically.
There was a problem hiding this comment.
Awesome! I'll check with @matt2e too and we can update the goplugin branch as well. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.