Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: buildengine publishes clearer state events #3168

Merged
merged 8 commits into from
Oct 22, 2024
Merged

Conversation

matt2e
Copy link
Contributor

@matt2e matt2e commented Oct 22, 2024

#2937

  • Module error state is now maintained, so that a changed file in one module getting successfully deployed does not get confused as "everything is good now"
  • CLI status bar updates now rely on these engine events, rather than being spread across the engine code
  • LSP uses EngineStarted and EngineEnded events to update status indicator
  • Bring all engine status update logs to one place, to align explicit build commands and plugin triggered builds

@ftl-robot ftl-robot mentioned this pull request Oct 22, 2024
@matt2e matt2e marked this pull request as ready for review October 22, 2024 05:21
@matt2e matt2e requested review from a team and alecthomas as code owners October 22, 2024 05:21
@matt2e matt2e requested review from deniseli and removed request for a team October 22, 2024 05:21
@matt2e matt2e force-pushed the matt2e/engine-events branch 3 times, most recently from e61cc3e to ad97a1d Compare October 22, 2024 22:33
@matt2e matt2e enabled auto-merge (squash) October 22, 2024 22:58
@matt2e matt2e merged commit 74b8bcf into main Oct 22, 2024
96 checks passed
@matt2e matt2e deleted the matt2e/engine-events branch October 22, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant