-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wait for provisioner #3140
Conversation
3977744
to
fe7e706
Compare
93b7aee
to
d04c190
Compare
9688e4b
to
8a660ea
Compare
@@ -27,7 +27,7 @@ type CommonProvisionerConfig struct { | |||
} | |||
|
|||
type Config struct { | |||
Bind *url.URL `help:"Socket to bind to." default:"http://127.0.0.1:8893" env:"FTL_PROVISIONER_BIND"` | |||
Bind *url.URL `help:"Socket to bind to." default:"http://127.0.0.1:8894" env:"FTL_PROVISIONER_BIND"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want to use one less than the default controller port...
8893 and can legitimately be taken up by other controllers, runners, language plugins etc.
As in running ftl build
could prevent the provisioner being able to start which is surprising.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(The language plugin stuff is only half in main atm)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been doing hacky step in a few places to try and not use the controller port in other commands: https://github.com/TBD54566975/ftl/blob/main/frontend/cli/cmd_schema_diff.go#L51
5bc2d51
to
a32156a
Compare
43d0418
to
a85b2e0
Compare
a85b2e0
to
4e433aa
Compare
No description provided.