fix: wait for provisioner #3140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
added
the
run-all
stuartwdouglas
requested review from
alecthomas
and removed request for
a team
stuartwdouglas
force-pushed
the
stuartwdouglas/provisioner-wait
branch
from
3977744
to
fe7e706
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/provisioner-wait
branch
6 times, most recently
from
93b7aee
to
d04c190
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/provisioner-wait
branch
3 times, most recently
from
9688e4b
to
8a660ea
Compare
matt2e
reviewed
Oct 17, 2024
| @@ -27,7 +27,7 @@ type CommonProvisionerConfig struct { | |||
| } | |||
|
|
|||
| type Config struct { | |||
| Bind *url.URL `help:"Socket to bind to." default:"http://127.0.0.1:8893" env:"FTL_PROVISIONER_BIND"` | |||
| Bind *url.URL `help:"Socket to bind to." default:"http://127.0.0.1:8894" env:"FTL_PROVISIONER_BIND"` | |||
There was a problem hiding this comment.
I wonder if we want to use one less than the default controller port...
8893 and can legitimately be taken up by other controllers, runners, language plugins etc.
As in running ftl build could prevent the provisioner being able to start which is surprising.
There was a problem hiding this comment.
(The language plugin stuff is only half in main atm)
There was a problem hiding this comment.
I've been doing hacky step in a few places to try and not use the controller port in other commands: https://github.com/TBD54566975/ftl/blob/main/frontend/cli/cmd_schema_diff.go#L51
stuartwdouglas
force-pushed
the
stuartwdouglas/provisioner-wait
branch
3 times, most recently
from
5bc2d51
to
a32156a
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/provisioner-wait
branch
2 times, most recently
from
43d0418
to
a85b2e0
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/provisioner-wait
branch
from
a85b2e0
to
4e433aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.