fix: prevent pubsub naming clashes (#3522)

Topic or subscription `a.b_c` would have previously clashed with `a_b.c` as we were separating module and name by underscores
TBD54566975 · Nov 26, 2024 · b72659f · b72659f
1 parent b2d950c
commit b72659f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/backend/provisioner/dev_provisioner.go b/backend/provisioner/dev_provisioner.go
@@ -265,11 +265,11 @@ func provisionSubscription() func(ctx context.Context, rc *provisioner.ResourceC
 }
 
 func kafkaTopicID(module, id string) string {
-	return shortenString(fmt.Sprintf("%s-%s", module, id), pubSubNameLimit)
+	return shortenString(fmt.Sprintf("%s.%s", module, id), pubSubNameLimit)
 }
 
 func consumerGroupID(module, id string) string {
-	return shortenString(fmt.Sprintf("%s-%s", module, id), pubSubNameLimit)
+	return shortenString(fmt.Sprintf("%s.%s", module, id), pubSubNameLimit)
 }
 
 // shortenString truncates the input string to maxLength and appends a hash of the original string for uniqueness