RecordsSubscribe #667
Merged
RecordsSubscribe #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
LiranCohen
force-pushed
the
lirancohen/records-subscribe
branch
2 times, most recently
from
a482c6c
to
5ef8e8e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #667 +/- ##
==========================================
+ Coverage 98.86% 98.90% +0.03%
==========================================
Files 75 77 +2
Lines 9678 10015 +337
Branches 1423 1468 +45
==========================================
+ Hits 9568 9905 +337
Misses 102 102
Partials 8 8 ☔ View full report in Codecov by Sentry. |
LiranCohen
force-pushed
the
lirancohen/records-subscribe
branch
from
8280c05
to
5b6d80f
Compare
…thorization property to prevent messageCid failure
LiranCohen
force-pushed
the
lirancohen/records-subscribe
branch
from
06babf3
to
20fbcb4
Compare
LiranCohen
requested review from
mistermoe,
csuwildcat and
thehenrytsai
as code owners
|
@thehenrytsai I've updated the PR based on comments and discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of the existing
EventStreamand adds a subscription specifically for theRecordsinterface which follows similar rules as those forRecordsQuery.Currently the subscription does not evict or re-authorize subscriptions after the initial processing of the message. So if a revocation of permissions happens after the subscription is live, the user will continue getting notified until they close the connection.
This will be addressed in a separate PR to keep things more concise and easier to follow. #668