This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tbd-website-developer-new ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tbd-website-developer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3 tasks
EbonyLouis
requested review from
dayhaysoos,
angiejones,
leordev,
blackgirlbytes and
acekyd
as code owners
June 28, 2024 15:45
KendallWeihe
reviewed
Jul 1, 2024
KendallWeihe
reviewed
Jul 1, 2024
...suites/testsuite-javascript/__tests__/tbdex/issuer/kcc/knownCustomerCredentialIssuer.test.js
Show resolved
Hide resolved
...suites/testsuite-javascript/__tests__/tbdex/issuer/kcc/knownCustomerCredentialIssuer.test.js
Show resolved
Hide resolved
angiejones
reviewed
Jul 1, 2024
...suites/testsuite-javascript/__tests__/tbdex/issuer/kcc/knownCustomerCredentialWallet.test.js
Outdated
Show resolved
Hide resolved
angiejones
reviewed
Jul 1, 2024
.../testsuite-kotlin/src/test/kotlin/docs/tbdex/issuer/kcc/KnownCustomerCredentialIssuerTest.kt
Outdated
Show resolved
Hide resolved
angiejones
approved these changes
Jul 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Based on this discussion:
KCC-Wallet
: Decodes JAR, Verify the JWT, decode its payload & Process SIOP RequestKCC Issuer
: Signs the SIOPv2 Auth Request and sends back in JAR formatQuestion / Issue
In order to sign the SIOPv2 Auth Request in Kotlin, it needs to be a
JwtClaimsSet
before signing. Is this okay to do or should we update Kotlin so we can sign the Auth Request when it's aJSON object
? However, it is allowed in JS. To keep it uniformed this is how its currently being done in this PR: (@KendallWeihe , @decentralgabe , @frankhinek , @tomdaffurn )TO DO:
web5-swift
on docs site first sinceJWT.verify()
was introduced 2 weeks ago.