-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux/GTK3] Some gamepad input rework #845
Conversation
thesourcehim
commented
Oct 10, 2024
- Unbind gamepad keys by default. The default bindings may fit one gamepad model but work weirdly with another causing issues like [LINUX/GTK3] Whitescreen freeze when pressing square on ds4 #834
- Use non-blocking method to obtain gamepad keys/axes during configuration to avoid visible emulator freeze and possible deadlock (see [linux] editing controlls sometimes (often) freezes the emulator #843)
I can confirm that completely this fixes #843 on my end |
@thesourcehim does this also supersede #822 ? if not, maybe you can take a look at whether the changes there make sense. |
In #822 I see changes related to how input config file is loaded and joystick events are processed for the main emu loop, some changes to cli frontend. My PR changes the default mappings for gamepad should config file lack gamepad input config, I didn't touch config file load algorithm. Also reworks input config dialog for GTK3 frontend. So I think these two PRs have different purpose. |
#822 never touches the gtk file, and this commit never touches the cli file |
@thesourcehim would you be able/willing to port this to GTK2 ? that way i could test it and merge if everything's fine. |
Ok, I can do it. |
gtk2 frontend (disabled by default). Fix meson.build dependency for gtk2.
@rofl0r done. |
thanks, works quite well. |
another thing is i'd recommend to use a feature branch for each PR you make, instead of pushing to your master - it doesn't mess up your git clone after some work was merged with changes, and it makes it easier for maintainers to check out your changes, rebase, etc. |