Staging sprint 11 #118
Merged
Staging sprint 11 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rfiles. Perform some upgrades to make the process more Java 17 friendly. Switch the base Dockerfile to be compliant with folio practices. Move our custom Dockerfile into a sub-directory under the newly created docker directory. Add dependency maven-shade-plugin to perform tasks necessary for folio standard build. Use the "-fat" nomenclature found in other FOLIO projects for this "shade" build. Upgraded exec-maven-plugin to 3.1.0 and maven-surefire-plugin to 3.2.1. Remove explicit versions for Camunda dependencies where being explicit is redundant.
While working on issue 115, these minor syntax and deprecated code issues were identified and resolved.
…ict. The generated package with `-fat` in the name is conflicting on the wildcard select in the build and run `Dockerfile`. Avoid this conflict by moving the `-fat` jar file into a sub-directory of `fat/` instead. Remove the `-fat` from the file name after doing this.
…from being added to git.
Issue 115: Java 17 and related upgrades.
…with standard FOLIO practices.
Relocate the the Descriptors.
The `descriptors/` directory should be at the base project root but in this specific case with service as a sub-directory the `descriptors/` directory must be under `service/`.
Rename the Descriptors to be a template and bring in the template processing plugins into the POM file.
Change the variable behavior in the Descriptors to be consistent with how standard FOLIO practices use them (`${project.version}` instead of `@project.version@` for example).
This module is again an exceptional case where the project is under `service/`.
The standard `${artifactId}` cannot be used because that ends up being `workflow-service` rather than `mod-workflow`.
Therefore, hard code `mod-workflow` in places where `mod-workflow` must be used instead of `workflow-service`.
Added `-XX:MaxRAMPercentage=66.0` for consistency with other projects.
Some projects use a value like 85.0.
I don't have a realistic clue here on what value to use and I am open to not having this environment variable set at all if a proposal to remove it is given.
The Deployment Descriptor used to have only `--server.port=%p`.
Other FOLIO projects have both `-Dport=%p` and `-Dhttp.port=%p`.
This plays it safe by having all three.
The amount of memory needed is currently unknown and so the provided `357913941` is used. The environment variables that are needed have yet to be fully hashed out. Only the specifically required environment variables are added. Others will needed to be added in another commit. see: https://dev.folio.org/guides/module-descriptor/ see: https://dev.folio.org/guides/install-backend-module/
Update the `application.yml` to utilize these. Update the default memory to 384MB.
Errors regarding multiple registrations of `AttributeConverter` have surfaced. This is a bug between the shade plugin and hibernate as far as I can tell from my online research. I believe that this is sufficient justification to deviate from the Folio practice of using the shade plugin. Strip out the shade plugin entirely and update the `Dockerfile`. I also noticed that the default `EXPOSE` for this project should be `9001` and not `9000`.
…anging 9001 to 8081.
Issue 113: Mod Workflow needs to be registered/deployed as a FOLIO module.
wwelling
approved these changes
Nov 16, 2023
rmathew1011
pushed a commit
that referenced
this pull request
Nov 5, 2024
MODWRKFLOW-20: Remove the build and run Dockerfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.