Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/WG-274: Update projects for next #232

Merged
merged 5 commits into from
Apr 30, 2024
Merged

task/WG-274: Update projects for next #232

merged 5 commits into from
Apr 30, 2024

Conversation

tjgrafft
Copy link
Contributor

@tjgrafft tjgrafft commented Apr 22, 2024 •
edited
Loading

Overview:

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  • Using ds_id instead of system_id in the Users panel because Designsafe-Next uses PRJ in its URL rather than the system uuid like previously. (Related to the two links in the Manage, Save tab on user panel)
  • Updated code to match structure of response data, as well as the URLs where the request are made on the new DS Next site
  • DesignsafeURL and Portal URL now use DS Next.
  • Projects request endpoint is now appropriately updated for new DS Next site.

Testing Steps:

UI Photos:

Notes:

Waiting for nginx conf to be merged for DS Next before merging this PR.

@tjgrafft tjgrafft changed the base branch from master to feature/tapisv3 April 22, 2024 21:11
nathanfranklin
nathanfranklin approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 great work.

@tjgrafft tjgrafft marked this pull request as ready for review April 24, 2024 13:21
@tjgrafft tjgrafft merged commit b5b1a87 into feature/tapisv3 Apr 30, 2024
5 checks passed
@tjgrafft tjgrafft deleted the task/WG-274-update-projects-for-next branch April 30, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanfranklin nathanfranklin nathanfranklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjgrafft @nathanfranklin