-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/WG-79: fix zoom level #138
Conversation
@@ -42,7 +42,7 @@ | |||
"leaflet": "^1.4.0", | |||
"leaflet.markercluster": "^1.4.1", | |||
"mapillary-js": "^4.1.0", | |||
"ng-tapis": "^2.1.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pinning to the exact version of ng-tapis as we have a newer version which is not suitable for master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a bunch of angry check annotation warnings, but the code looks good to me!
fixed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Overview:
This PR fixes zoom level on the project load and also when selecting asset.
Hazmapper fits to project bounds when loading and fits a single asset bound when the asset is selected which for points can be the max zoom of our entire map which is too high. Now, we have max zoom of 18 when zooming to assets or to the entire project.
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
angular/src/environments/environment.ts
setbackend
to EnvironmentType.Production or EnvironmentType.Stagingnpm run start:local
UI Photos:
Before:
After: