Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/WG-79: fix zoom level #138

Merged
merged 4 commits into from
Jun 2, 2023
Merged

Conversation

nathanfranklin
Copy link
Collaborator

Overview:

This PR fixes zoom level on the project load and also when selecting asset.

Hazmapper fits to project bounds when loading and fits a single asset bound when the asset is selected which for points can be the max zoom of our entire map which is too high. Now, we have max zoom of 18 when zooming to assets or to the entire project.

PR Status:

  • Ready.

Related Jira tickets:

Summary of Changes:

Testing Steps:

  1. set angular/src/environments/environment.ts set backend to EnvironmentType.Production or EnvironmentType.Staging
    npm run start:local
  2. Go to http://hazmapper.local:4200/
  3. Find project with asset
  4. Click on an asset and confirm zoom isn't as close as what you would see when viewing the project hazmapper.tacc.utexas.edu/hazmapper
  5. OIf the project has just one asset, you can also confirm that when it loads that it doesn't zoom as close as production.

UI Photos:

Before:
Screenshot 2023-06-02 at 12 05 19 PM

After:

Screenshot 2023-06-02 at 12 04 52 PM

@@ -42,7 +42,7 @@
"leaflet": "^1.4.0",
"leaflet.markercluster": "^1.4.1",
"mapillary-js": "^4.1.0",
"ng-tapis": "^2.1.6",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pinning to the exact version of ng-tapis as we have a newer version which is not suitable for master

Copy link
Contributor

@taoteg taoteg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a bunch of angry check annotation warnings, but the code looks good to me!

@nathanfranklin
Copy link
Collaborator Author

I see a bunch of angry check annotation warnings, but the code looks good to me!

fixed 👍

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanfranklin nathanfranklin merged commit 17b4aae into master Jun 2, 2023
@nathanfranklin nathanfranklin deleted the task/WG-79-fix-zoom-level branch June 2, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants